pipelines: filters: parser: Add a nest_under parameter #1543
Conversation
Signed-off-by: Ra'Jiska <[email protected]>
RaJiska
force-pushed
the
filter-parser-nest-under
branch
from
6458fe0 to
e76f785
Compare
alexakreizinger
left a comment
alexakreizinger
left a comment
There was a problem hiding this comment.
made a few suggestions for style and clarity, but LGTM!
and thanks for opening a PR :)
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Doriann Corlouër <[email protected]>
|
All good to me! Thanks @alexakreizinger for helping making it clearer and in proper English~~ |
|
Hi @alexakreizinger , I'm not entirely sure how the PR flow happens on this repo, but I see it has been merged already, yet the PR linked to this documentation hasn't been approved nor merged yet. If this goes live this might cause discrepancy between the documentation and actual options available until the referenced PR is merged as well. |
I've just spent a good 30 minutes scratching my head as to why |
|
@RaJiska, thanks for pointing out this discrepancy! We reverted the docs change until the related linked PR is merged with the appropriate code changes. |
4 participants
Documentation for PR fluent/fluent-bit#9828